Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Form::select to blade component #16065

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Jan 14, 2025

Copy link

what-the-diff bot commented Jan 14, 2025

PR Summary

  • Implemented a New Blade Component:

    • Introduced a new component for dropdown selections, simplifying the code and improving readability.
  • Transitioned to Custom Component:

    • Several select elements throughout the application have been updated to use the new component. These updates were made in various areas including category type selection, status identification, and more.
  • Improved Dropdown Functionality:

    • The custom component enhances the management of options and selected states, driving efficiency by promoting code reuse.
  • Incorporated Livewire for Real-Time Updates:

    • Many instances now include attributes for Livewire functionality, enhancing real-time form updates.
  • Enhanced Error Handling:

    • Revised the error handling process to remain effective while simplifying select element definitions.
  • Overall Code Refactoring:

    • Removal of repetitive code reduces complexity and improves maintainability across forms using selections.
  • Deprecated Files Removal:

    • Certain files, like category.blade.php, company.blade.php and others, were deleted possibly as part of a refactoring or consolidation process.
  • Utilization of new Component in Various Views:

    • Form elements in branding.blade.php, various edit view files and settings related to dashboard configuration have migrated to using the new component, improving the user experience.
  • Increased Accessibility:

    • The new component also includes an aria-label for improved accessibility. This entails that the component is better suited for users with special needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant